Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix examples to appropriate type #4974

Merged
merged 2 commits into from
Oct 30, 2020
Merged

fix examples to appropriate type #4974

merged 2 commits into from
Oct 30, 2020

Conversation

IsaacPD
Copy link
Contributor

@IsaacPD IsaacPD commented Oct 30, 2020

Fixes: #4970

Description

Change examples to be wrapped in an array and have the names be wrapped in quotations.

@IsaacPD IsaacPD requested review from MarlonGamez and a team October 30, 2020 00:21
@google-cla google-cla bot added the cla: yes label Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #4974 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4974      +/-   ##
==========================================
- Coverage   72.34%   72.27%   -0.08%     
==========================================
  Files         360      361       +1     
  Lines       12564    12640      +76     
==========================================
+ Hits         9090     9135      +45     
- Misses       2808     2827      +19     
- Partials      666      678      +12
Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/deploy/kpt/kpt.go 73.92% <0.00%> (-5.59%) ⬇️
pkg/skaffold/deploy/helm/helm.go 74.11% <0.00%> (-0.51%) ⬇️
pkg/skaffold/util/http.go 50.00% <0.00%> (ø)
pkg/skaffold/util/util.go 83.33% <0.00%> (+0.93%) ⬆️
pkg/skaffold/update/update.go 45.45% <0.00%> (+6.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d667827...01a3c7f. Read the comment docs.

@MarlonGamez MarlonGamez added the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
@container-tools-bot
Copy link

Please visit http://34.94.209.155:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
@IsaacPD IsaacPD added the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
@container-tools-bot
Copy link

Please visit http://34.94.160.70:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 30, 2020
MarlonGamez
MarlonGamez approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this through :)

@IsaacPD IsaacPD merged commit cd2a38f into GoogleContainerTools:master Oct 30, 2020
@tejal29
Copy link
Member

tejal29 commented Oct 30, 2020

Thanks. I will regenerate the docs!

@tejal29 tejal29 mentioned this pull request Oct 30, 2020
Closed
@IsaacPD IsaacPD deleted the fix-docs branch October 30, 2020 15:05
@fmotrifork fmotrifork mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation reference of skaffold.yaml is empty
4 participants
@IsaacPD @container-tools-bot @tejal29 @MarlonGamez